feat(safer-cluster): add some missing variables #2429
Conversation
There was a problem hiding this comment.
Thanks for the contribution @bergemalm
Can you please build the templates and add to the commit: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/CONTRIBUTING.md#templating
- node_pools_resource_manager_tags - node_pools_linux_node_configs_sysctls - node_pools_cgroup_mode - node_pools_hugepage_size_2m - node_pools_hugepage_size_1g - enable_secret_manager_addon
bergemalm
force-pushed
the
safer-clusters-missing-variables
branch
from
95b1031 to
49f136d
Compare
Done. @apeabody |
|
/gcbrun |
|
Checking in on this one. Any reason for not adding this one on last release? @apeabody |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several new variables to the safer-cluster modules, exposing more configuration options for GKE node pools and enabling the Secret Manager addon. The changes are mostly boilerplate and have been applied across multiple generated files. I've identified a few minor issues related to formatting, ordering, and a description that could be improved for consistency and maintainability.
|
|
||
| variable "node_pools_hugepage_size_1g" { | ||
| type = map(string) | ||
| description = "Map of strings containing hugepage size 1g config by node-pool name" |
There was a problem hiding this comment.
For consistency with other variable descriptions like node_pools_cgroup_mode, please add the word "node" to this description.
description = "Map of strings containing hugepage size 1g node config by node-pool name"
|
/gcbrun |
2 participants
This PR adds some missing variables in the safer-cluster modules.
Closes #2369